fix(packaging): add setuptools to dev extra so packaging test collects - #34854
Closed
teknium1 wants to merge 1 commit into
Closed
fix(packaging): add setuptools to dev extra so packaging test collects#34854teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
Contributor
|
Contributor
🔎 Lint report:
|
tests/test_packaging_metadata.py (added in #34811) imports `from setuptools import find_packages` at module level. setuptools is only declared under [build-system] requires, not as a runtime/test dep, so CI's uv-managed test venv (uv pip install -e '.[all,dev]') lacks it and the module errors at collection with ModuleNotFoundError. Adding setuptools>=61.0 to the dev extra keeps the wheel-packaging regression test running in CI instead of skipping or erroring.
teknium1
force-pushed
the
fix/packaging-test-setuptools-dep
branch
from
May 29, 2026 20:33
170a09f to
52524c7
Compare
Collaborator
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_packaging_metadata.py(added in #34811) now collects in CI instead of erroring out.The test imports
from setuptools import find_packagesat module level.setuptoolsis declared only under[build-system].requires, not as a runtime/test dependency — so CI's uv-managed test venv (uv pip install -e ".[all,dev]") doesn't have it, and the module fails at collection withModuleNotFoundError: No module named 'setuptools'. This shows up as a redtest (slice 4/6)shard on every PR branched off main since #34811 landed, even though all 4026 tests pass.Changes
pyproject.toml: addsetuptools>=61.0to thedevextra (matching the[build-system]pin), so the wheel-packaging regression test keeps running in CI rather than being skipped or erroring.uv.lock: regenerated (setuptools was already a transitive entry; just adds it to theall/devextra references).Validation
Before:
ERROR collecting tests/test_packaging_metadata.py→ModuleNotFoundError: No module named 'setuptools'→ shard 4 red.