Skip to content

fix(mcp): require Google Drive OAuth client credentials and real login - #34787

Closed
nehaprasad-dev wants to merge 1 commit into
NousResearch:mainfrom
nehaprasad-dev:fix/off-mcp-aut-time-out
Closed

fix(mcp): require Google Drive OAuth client credentials and real login#34787
nehaprasad-dev wants to merge 1 commit into
NousResearch:mainfrom
nehaprasad-dev:fix/off-mcp-aut-time-out

Conversation

@nehaprasad-dev

Copy link
Copy Markdown

What does this PR do?

  • Fixes Google Drive MCP OAuth: require client_id/client_secret, real login via tool call, fail fast instead of 120s timeout.

Related Issue

Type of Change

  • Bug fix
Changes Made
  • Validate Drive MCP OAuth config (tools/mcp_oauth.py, mcp_oauth_manager.py)
  • Login runs authenticated probe + checks tokens (hermes_cli/mcp_config.py)
  • Fast auth errors on tool calls (tools/mcp_tool.py)

Tests

How to Test

  • Config: auth: oauth + oauth.client_id / client_secret for https://drivemcp.googleapis.com/mcp/v1
  • hermes mcp login → browser OAuth, tokens in ~/.hermes/mcp-tokens/
  • Use a Drive MCP tool — no timeout

Checklist

Code

  • Contributing Guide read
  • Conventional Commits
  • No duplicate PR

Only related changes

Full pytest tests/ -q

Tests added

Platform tested: Ubuntu WSL
Documentation & Housekeeping

Docs — N/A

cli-config.yaml.example — N/A

CONTRIBUTING.md / AGENTS.md — N/A

Cross-platform — N/A

Tool schemas — N/A

Screenshots / Logs

Optional: login without URL vs with credentials; tool call success vs old timeout.

Google Drive MCP rejects dynamic client registration; validate client_id,
run an authenticated probe on login, and fail fast on registration errors.

Co-authored-by: Cursor <cursoragent@cursor.com>
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists tool/mcp MCP client and OAuth comp/cli CLI entry point, hermes_cli/, setup wizard labels May 29, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused Google Drive MCP investigation. This is an automated hermes-sweeper review; current main already implements the reported behavioral fix.

Closing as implemented on main.

@teknium1 teknium1 closed this Jul 13, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main tool/mcp MCP client and OAuth type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Official MCP server for Google Drive authenticates successfully, then always times out for any tool

3 participants