fix(gateway): notify home channel after service-managed restart - #34739
Closed
spiky02plateau wants to merge 1 commit into
Closed
fix(gateway): notify home channel after service-managed restart#34739spiky02plateau wants to merge 1 commit into
spiky02plateau wants to merge 1 commit into
Conversation
spiky02plateau
force-pushed
the
fix/gateway-service-restart-startup-notify
branch
2 times, most recently
from
May 29, 2026 17:16
b0ee74b to
ea03fd9
Compare
Collaborator
spiky02plateau
force-pushed
the
fix/gateway-service-restart-startup-notify
branch
from
May 29, 2026 19:12
ea03fd9 to
9a421c8
Compare
Contributor
|
Thanks for the careful lifecycle-notification work. This is an automated hermes-sweeper review; current
The member discussion correctly distinguished this from direct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes gateway lifecycle notifications for service-manager / graceful-signal restarts. When the gateway successfully sends the pre-shutdown home-channel warning, it now records a short-lived startup marker and sends a matching "back up" notification to that same home target after the next startup settles.
Related Issue
No linked issue.
Type of Change
Changes Made
.restart_notify.jsonscoped to direct/restartrequester completion messages..startup_notify.jsonmarker for graceful signal/service-manager restarts._notify_active_sessions_of_shutdown, awaited by_stop_implwith no surrounding try, so an unguarded raise would skip the rest of teardown).♻ Gateway restarted successfully. Hermes is back and ready.gateway_restart_notification=false./restart, marker, and generic home-channel startup notifications.How to Test
Targeted verification run after rebasing onto current
origin/main:python -m pytest tests/gateway/test_restart_notification.py -q -o 'addopts='python -m pytest tests/gateway/test_restart_redelivery_dedup.py -q -o 'addopts='python -m pytest tests/gateway/test_restart_notification.py tests/gateway/test_restart_redelivery_dedup.py -q -o 'addopts='python -m py_compile gateway/run.py tests/gateway/test_restart_notification.py tests/gateway/test_restart_redelivery_dedup.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
cli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/ANotes
A broader
python -m pytest tests/gateway -qrun hitOSError: [Errno 24] Too many open fileson macOS — pre-existing gateway test-infra/file-descriptor debt, not a regression from this patch. The targeted restart suites stay clean (43 passed).