fix(gateway): guard chained .get() against None intermediate values

[annguyenNous]

Summary

.get("key", {}) only applies the default {} when the key is absent from the dict. When the key exists with value None (null in JSON/API responses), .get() returns None and the subsequent .get() raises AttributeError.

This is the same pattern documented in Pitfall 28 — .get(key, default) vs .get(key) or default.

Fix

Replace .get("key", {}).get(...) with (.get("key") or {}).get(...) which handles both missing keys AND None values.

Affected locations (8 instances, 6 files)

File	Line	Context	Severity
gateway/run.py	11629	tool_call function name for TTS filter	Low-Med
acp_adapter/server.py	1700-1701	tool name/description extraction	Low-Med
gateway/platforms/qqbot/onboard.py	103	API response task_id extraction	Low-Med
gateway/platforms/yuanbao.py	2022, 2041	message content parsing (x2)	Low-Med
gateway/platforms/slack.py	2434, 2535	block text extraction (x2)	Low
tui_gateway/server.py	3360	error message extraction	Low

Impact

All instances involve parsing external API responses or tool call structures where null/None values are possible. The crash manifests as AttributeError: 'NoneType' object has no attribute 'get'.

[teknium1]

Thanks for identifying a real defensive-parsing issue. The premise still holds on current main, but this branch needs targeted salvage before it can provide the stated coverage.

Problems

• The Slack edits target gateway/platforms/slack.py, but the live handlers moved to plugins/platforms/slack/adapter.py in 5600105478ffde29d7566b45421b100eaa29c4ef; the unsafe chains remain at plugins/platforms/slack/adapter.py:3514 and :3636.
• The Yuanbao methods remain unsafe at gateway/platforms/yuanbao.py:2156 and :2175 on current main.
• ACP has a sibling unsafe access over the same tool list at acp_adapter/server.py:1800, in addition to the two display accesses changed by this PR.
• The six-file diff contains no regression test for present-but-null intermediates.

Suggested changes

• Port the Slack and Yuanbao guards to their current locations, guard the ACP sibling, and add focused null-intermediate regression tests.

Automated hermes-sweeper review.

[teknium1]

This handler has moved on current main: please port this guard to plugins/platforms/slack/adapter.py:3514 (and the matching approval handler at :3636), otherwise the active Slack code remains unguarded.

[teknium1]

Please also guard the sibling tool.get("function", {}).get("name") used to build valid_tool_names; on current main it is in the same _cmd_tools flow at acp_adapter/server.py:1800.

[teknium1]

Merged via #70196 — your commit was cherry-picked/reapplied onto current main with your authorship preserved in git history: your None-intermediate guards were cherry-picked.

Thanks for the contribution!