docs(kanban): document POST /runs/{run_id}/terminate worker-terminate endpoint (#34449) - #34673
Closed
r266-tech wants to merge 1 commit into
Closed
docs(kanban): document POST /runs/{run_id}/terminate worker-terminate endpoint (#34449)#34673r266-tech wants to merge 1 commit into
r266-tech wants to merge 1 commit into
Conversation
Contributor
|
Thanks for documenting the worker-termination control surface. This is an automated hermes-sweeper review: current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#34449 added a kanban REST control endpoint to terminate a live worker run —
plugins/kanban/dashboard/plugin_api.py:@router.post("/runs/{run_id}/terminate")(TerminateRunBody), routing throughkanban_db.reclaim_task(SIGTERM→SIGKILL + run-outcome bookkeeping + event-log append), returning{"ok": true, "run_id": ..., "task_id": ...}(404 unknown run / 409 already-ended). Its own docstring notes it "closes the gap left by PR #28432, which shipped the read-only sibling endpoints but no termination control surface."The Worker visibility endpoints section only documented the three read-only GET endpoints. This adds the terminate control to the table (kept distinct from the read-only set) and updates the surrounding prose. Pure docs.