Skip to content

guard Yuanbao media URL downloads - #34591

Closed
afurm wants to merge 1 commit into
NousResearch:mainfrom
afurm:af/yuanbao-media-ssrf-guard
Closed

guard Yuanbao media URL downloads#34591
afurm wants to merge 1 commit into
NousResearch:mainfrom
afurm:af/yuanbao-media-ssrf-guard

Conversation

@afurm

@afurm afurm commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apply URL safety checks before Yuanbao media downloads create an HTTP client
  • install a redirect guard for followed media redirects
  • keep Yuanbao-resolved resource hosts as an explicit opt-in path for private-IP resolution while preserving metadata endpoint blocking

Tests

  • .venv/bin/python -m pytest -o addopts='' tests/gateway/test_yuanbao_media.py tests/gateway/platforms/test_yuanbao_recall_db_only.py tests/test_yuanbao_pipeline.py tests/test_yuanbao_markdown.py tests/test_yuanbao_proto.py

@alt-glitch alt-glitch added type/security Security vulnerability or hardening comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists labels May 29, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #22340 — both add SSRF guards (url_safety check + redirect guard) to Yuanbao media downloads. #22340 was opened first and is already triaged.

@afurm

afurm commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for flagging it. I missed #22340; closing this one as a duplicate.

@afurm afurm closed this May 29, 2026
@afurm
afurm deleted the af/yuanbao-media-ssrf-guard branch May 29, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists type/security Security vulnerability or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants