fix(telegram): strip raw markdown in MarkdownV2 fallback paths - #34570
Closed
Vitalymt wants to merge 1 commit into
Closed
fix(telegram): strip raw markdown in MarkdownV2 fallback paths#34570Vitalymt wants to merge 1 commit into
Vitalymt wants to merge 1 commit into
Conversation
When Telegram rejects MarkdownV2 formatting in edit_message (e.g. during streaming finalization), the fallback was sending raw content with literal **bold** markers and no parse_mode. This caused users to see raw markdown syntax instead of plain text. Three fixes: - _strip_mdv2(): add regex to strip raw **bold** before converted *bold* - edit_message fallback: use _strip_mdv2(content) + parse_mode=None - flood control retry: use already-formatted text or _strip_mdv2 fallback Fixes the inconsistency where send() properly fell back to _strip_mdv2() but edit_message() did not.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Telegram rejects MarkdownV2 in edit_message (e.g. during streaming
finalization of multi-chunk responses), the fallback sends raw content
with literal bold markers and no parse_mode. Users see raw markdown
syntax instead of formatted or plain text.
Fix
Reproduced with long streamed responses split into chunks where the
second chunk (with inline buttons) triggered a MarkdownV2 parse error.