Skip to content

fix(security): deny entire HERMES_HOME tree in media delivery denylist #34425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
teknium1 wants to merge 1 commit into from
Closed

fix(security): deny entire HERMES_HOME tree in media delivery denylist #34425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions gateway/platforms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,11 +947,14 @@ def _media_delivery_denied_paths() -> List[Path]:
home = Path(os.path.expanduser("~"))
for sub in _MEDIA_DELIVERY_DENIED_HOME_SUBPATHS:
denied.append(home / sub)
# The Hermes home itself contains credentials (auth.json, .env) — only the
# cache subdirectories under it are explicitly allowlisted above.
denied.append(_HERMES_HOME / ".env")
denied.append(_HERMES_HOME / "auth.json")
denied.append(_HERMES_HOME / "credentials")
# Deny the entire Hermes home directory tree. It contains credentials
# (auth.json, .env, mcp-tokens/, pairing/, .anthropic_oauth.json, etc.)
# that must never be delivered as gateway attachments regardless of mtime.
# Cache subdirectories within HERMES_HOME (image_cache/, cache/documents/,
# etc.) live in MEDIA_DELIVERY_SAFE_ROOTS and are returned by the allowlist
# check before this denylist is ever consulted — denying HERMES_HOME here
# does not affect legitimate cache deliveries.
denied.append(_HERMES_HOME)
return denied


Expand Down
Loading