Skip to content

fix(supermemory): honor auto_capture on session end - #34136

Closed
martinramos002-bot wants to merge 1 commit into
NousResearch:mainfrom
martinramos002-bot:fix/supermemory-auto-capture-session-end
Closed

fix(supermemory): honor auto_capture on session end#34136
martinramos002-bot wants to merge 1 commit into
NousResearch:mainfrom
martinramos002-bot:fix/supermemory-auto-capture-session-end

Conversation

@martinramos002-bot

Copy link
Copy Markdown
Contributor

Summary

  • Make Supermemory on_session_end() return early when auto_capture is disabled.
  • Add a regression test so session-end conversation ingest follows the same capture opt-out as per-turn sync.

Test Plan

  • python -m pytest -o addopts='' tests/plugins/memory/test_supermemory_provider.py -q
  • python -m ruff check plugins/memory/supermemory/__init__.py tests/plugins/memory/test_supermemory_provider.py

No private data or local paths are included; the test uses synthetic fixture messages.

Copilot AI review requested due to automatic review settings May 28, 2026 22:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Supermemory provider to skip ingesting session messages when auto-capture is disabled, and adds a regression test to confirm this behavior.

Changes:

  • Gate on_session_end ingestion behind the _auto_capture flag.
  • Add a unit test ensuring no ingest occurs when _auto_capture is False.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/plugins/memory/test_supermemory_provider.py Adds coverage for on_session_end behavior when auto-capture is disabled.
plugins/memory/supermemory/init.py Updates on_session_end to respect the _auto_capture setting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +172 to +173
def test_on_session_end_respects_auto_capture_false(provider):
provider._auto_capture = False
@martinramos002-bot
martinramos002-bot force-pushed the fix/supermemory-auto-capture-session-end branch from 3f0ed73 to 178da01 Compare May 28, 2026 22:26
@martinramos002-bot

Copy link
Copy Markdown
Contributor Author

Thanks — addressed the Copilot nit in the latest push (178da018):

  • Updated the regression test to configure auto_capture: false through the provider config file before initialize(), rather than mutating the private _auto_capture attribute directly.
  • Re-ran validation:
    • python -m pytest -o addopts='' tests/plugins/memory/test_supermemory_provider.py -q30 passed
    • python -m ruff check plugins/memory/supermemory/__init__.py tests/plugins/memory/test_supermemory_provider.py → passed

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins tool/memory Memory tool and memory providers duplicate This issue or pull request already exists labels May 29, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #24136 (same one-line _auto_capture guard in on_session_end()). Both are subsumed by #21692 which includes this fix plus additional memory bounds.

@martinramos002-bot

Copy link
Copy Markdown
Contributor Author

Thanks for the pointer — agreed. This is covered by #24136 and more broadly by #21692, so I’m closing this duplicate to avoid competing review threads. We’ll track #21692 for absorbing the local Supermemory auto_capture safeguard once it lands in an official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants