fix(supermemory): honor auto_capture on session end - #34136
Closed
martinramos002-bot wants to merge 1 commit into
Closed
fix(supermemory): honor auto_capture on session end#34136martinramos002-bot wants to merge 1 commit into
martinramos002-bot wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Supermemory provider to skip ingesting session messages when auto-capture is disabled, and adds a regression test to confirm this behavior.
Changes:
- Gate
on_session_endingestion behind the_auto_captureflag. - Add a unit test ensuring no ingest occurs when
_auto_captureisFalse.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/plugins/memory/test_supermemory_provider.py | Adds coverage for on_session_end behavior when auto-capture is disabled. |
| plugins/memory/supermemory/init.py | Updates on_session_end to respect the _auto_capture setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+172
to
+173
| def test_on_session_end_respects_auto_capture_false(provider): | ||
| provider._auto_capture = False |
martinramos002-bot
force-pushed
the
fix/supermemory-auto-capture-session-end
branch
from
May 28, 2026 22:26
3f0ed73 to
178da01
Compare
Contributor
Author
|
Thanks — addressed the Copilot nit in the latest push (
|
Collaborator
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_session_end()return early whenauto_captureis disabled.Test Plan
python -m pytest -o addopts='' tests/plugins/memory/test_supermemory_provider.py -qpython -m ruff check plugins/memory/supermemory/__init__.py tests/plugins/memory/test_supermemory_provider.pyNo private data or local paths are included; the test uses synthetic fixture messages.