-
Notifications
You must be signed in to change notification settings - Fork 48.1k
fix(cli): make classic CLI /indicator command branch aware #34133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dusk1e
wants to merge
1
commit into
NousResearch:main
Choose a base branch
from
Dusk1e:fix/cli-indicator-command-dispatch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+117
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| """Tests for the /indicator CLI command.""" | ||
|
|
||
| import unittest | ||
| from types import SimpleNamespace | ||
| from unittest.mock import patch | ||
|
|
||
|
|
||
| def _import_cli(): | ||
| import hermes_cli.config as config_mod | ||
|
|
||
| if not hasattr(config_mod, "save_env_value_secure"): | ||
| config_mod.save_env_value_secure = lambda key, value: { | ||
| "success": True, | ||
| "stored_as": key, | ||
| "validated": False, | ||
| } | ||
|
|
||
| import cli as cli_mod | ||
|
|
||
| return cli_mod | ||
|
|
||
|
|
||
| class TestHandleIndicatorCommand(unittest.TestCase): | ||
| def test_no_args_shows_normalized_status(self): | ||
| cli_mod = _import_cli() | ||
| stub = SimpleNamespace() | ||
| with ( | ||
| patch.object(cli_mod, "_cprint") as mock_cprint, | ||
| patch("hermes_cli.config.load_config", return_value={"display": {"tui_status_indicator": " EMOJI "}}), | ||
| patch.object(cli_mod, "save_config_value") as mock_save, | ||
| ): | ||
| cli_mod.HermesCLI._handle_indicator_command(stub, "/indicator") | ||
|
|
||
| mock_save.assert_not_called() | ||
| printed = " ".join(str(call) for call in mock_cprint.call_args_list) | ||
| self.assertIn("emoji", printed.lower()) | ||
| self.assertIn("dashboard", printed.lower()) | ||
|
|
||
| def test_valid_argument_saves_lowercased_style(self): | ||
| cli_mod = _import_cli() | ||
| stub = SimpleNamespace() | ||
| with ( | ||
| patch.object(cli_mod, "_cprint"), | ||
| patch.object(cli_mod, "save_config_value", return_value=True) as mock_save, | ||
| ): | ||
| cli_mod.HermesCLI._handle_indicator_command(stub, "/indicator EMOJI") | ||
|
|
||
| mock_save.assert_called_once_with("display.tui_status_indicator", "emoji") | ||
|
|
||
| def test_invalid_argument_prints_usage_without_saving(self): | ||
| cli_mod = _import_cli() | ||
| stub = SimpleNamespace() | ||
| with ( | ||
| patch.object(cli_mod, "_cprint") as mock_cprint, | ||
| patch.object(cli_mod, "save_config_value") as mock_save, | ||
| ): | ||
| cli_mod.HermesCLI._handle_indicator_command(stub, "/indicator sparkle") | ||
|
|
||
| mock_save.assert_not_called() | ||
| printed = " ".join(str(call) for call in mock_cprint.call_args_list) | ||
| self.assertIn("unknown indicator", printed.lower()) | ||
| self.assertIn("ascii|emoji|kaomoji|unicode", printed.lower()) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current main extracted
_handle_*_commandmethods intohermes_cli/cli_commands_mixin.py(_handle_skin_commandis now there at line 2250). Please move this handler and its local validation support into that mixin; keep only the dispatch branch incli.py.