fix(auth): share Codex OAuth pool across profiles - #34121
Closed
vishutdhar wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
|
Thanks for addressing the real single-use Codex refresh-token hazard. This automated hermes-sweeper review found that current
Closing as implemented on main. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openai-codexcredential-pool entries from the global root auth store in profile mode.Why
Codex OAuth refresh tokens are single-use. If profile-local pools keep separate copies, one profile can refresh and rotate the token while another profile keeps using a stale refresh token. Sharing the Codex pool in profile mode gives workers one source of truth for the active token pair.
Tests
scripts/run_tests.sh -j 2 tests/hermes_cli/test_auth_codex_provider.py tests/agent/test_credential_pool.py -- -qscripts/run_tests.sh -j 2 tests/hermes_cli/test_auth_commands.py -- -q -k 'codex or credential_pool or write_credential_pool'.venv/bin/python -m py_compile hermes_cli/auth.py agent/credential_pool.pygit diff --check