feat(models): add Claude Opus 4.8 - #34014
Closed
Couiz wants to merge 1 commit into
Closed
Conversation
- hermes_cli/models.py: add to OpenRouter, Nous, and native Anthropic lists - agent/model_metadata.py: 1M context for claude-opus-4-8/4.8 - agent/anthropic_adapter.py: 4-8/4.8 -> xhigh effort, adaptive thinking, no-sampling-params contract (inherits Opus 4.7 contract); 128k output limit - website/static/api/model-catalog.json: regenerated manifest Model ID verified live against Anthropic /v1/models (claude-opus-4-8).
Author
|
Closing as superseded — #34003 ("feat: add claude-opus-4.8 and claude-opus-4.8-fast") landed on main first and covers everything here: identical adapter substring gates ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Claude Opus 4.8 across all four layers Hermes uses to know an Anthropic model.
hermes_cli/models.py— adds the model toOPENROUTER_MODELS(anthropic/claude-opus-4.8),_PROVIDER_MODELS["nous"], and the native_PROVIDER_MODELS["anthropic"]list (claude-opus-4-8).agent/model_metadata.py— 1M context window for bothclaude-opus-4-8andclaude-opus-4.8, inserted before the 4.7 entries to avoid fuzzy-match collisions.agent/anthropic_adapter.py— adds4-8/4.8to the substring gates so Opus 4.8 inherits the Opus 4.7 contract:_XHIGH_EFFORT_SUBSTRINGS→xhighadaptive effort (not downgraded tomax)_ADAPTIVE_THINKING_SUBSTRINGS→ adaptive thinking_NO_SAMPLING_PARAMS_SUBSTRINGS→ omits temperature/top_p/top_k (4.7+ returns 400 otherwise)_ANTHROPIC_OUTPUT_LIMITS["claude-opus-4-8"] = 128_000website/static/api/model-catalog.json— regenerated viascripts/build_model_catalog.pyto keep the published manifest in sync with the curated lists.Verification
GET /v1/modelsreturnsclaude-opus-4-8, no dated suffix — same shape asclaude-opus-4-7).xhigh=True,adaptive=True,no-sampling=Trueforclaude-opus-4-8,claude-opus-4.8, andanthropic/claude-opus-4.8.'4-8' in 'claude-opus-4-7'isFalse.Test Plan
pytest tests/agent/test_anthropic_adapter.py tests/hermes_cli/test_models.py tests/hermes_cli/test_model_catalog.py tests/hermes_cli/test_model_validation.py→ 334 passedtest_in_repo_lists_match_manifest) passes after regeneration