fix: isolate kanban dispatcher sqlite board failures - #33929
Open
the24thLetter wants to merge 30 commits into
Open
the24thLetter wants to merge 30 commits into
the24thLetter wants to merge 30 commits into
Conversation
This was referenced May 28, 2026
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the board-local diagnostic work. The core corrupt-board isolation is already present on current main (gateway/kanban_watchers.py:943-1055, from d37574775 and c94ad8981), but the disk-I/O/WAL diagnostics remain a distinct enhancement.
Problems
- Blocking:
gateway/run.py:5861delegates to_dispatch_kanban_board_once, but that helper only forwardsboard,max_spawn,max_in_progress,stale_timeout_seconds, andfailure_limit(gateway/run.py:1320-1328). It drops the existingdefault_assigneeandmax_in_progress_per_profileforwarding that current main retains atgateway/kanban_watchers.py:1016-1025. This regresses configured default assignment and per-profile concurrency caps.
Suggested changes
- Preserve and test both configuration values through the extracted helper.
- Salvage the watcher change onto
gateway/kanban_watchers.py; current main moved this watcher there in1c68f6f81.
Automated hermes-sweeper review.
| # and issue #21378. `_dispatch_kanban_board_once` also handles | ||
| # board-local SQLite quarantine so one bad board cannot break | ||
| # gateway-embedded dispatch for the others. | ||
| return _dispatch_kanban_board_once( |
Collaborator
There was a problem hiding this comment.
Blocking: this helper call no longer forwards default_assignee or max_in_progress_per_profile. Current main passes both to dispatch_once; preserve them in _dispatch_kanban_board_once and add a regression test so configured default assignment and per-profile concurrency limits do not silently revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
python -m py_compile gateway/run.py hermes_cli/kanban_db.py plugins/kanban/dashboard/plugin_api.py tests/gateway/test_kanban_dispatch_quarantine.py tests/hermes_cli/test_kanban_db.py tests/plugins/test_kanban_worker_runs.pyenv -u HERMES_KANBAN_DB -u HERMES_KANBAN_BOARD -u HERMES_KANBAN_REQUIRE_REVIEW_BEFORE_DONE -u HERMES_KANBAN_MERGE_CAPTAIN_PROFILE -u HERMES_KANBAN_WORKSPACES_ROOT python -m pytest tests/gateway/test_kanban_dispatch_quarantine.py tests/plugins/test_kanban_worker_runs.py tests/hermes_cli/test_kanban_notify.py -q -o 'addopts='(31 passed)env -u HERMES_KANBAN_DB -u HERMES_KANBAN_BOARD -u HERMES_KANBAN_REQUIRE_REVIEW_BEFORE_DONE -u HERMES_KANBAN_MERGE_CAPTAIN_PROFILE -u HERMES_KANBAN_WORKSPACES_ROOT python -m pytest tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts='(101 passed, 1 warning)env -u HERMES_KANBAN_DB -u HERMES_KANBAN_BOARD -u HERMES_KANBAN_REQUIRE_REVIEW_BEFORE_DONE -u HERMES_KANBAN_MERGE_CAPTAIN_PROFILE -u HERMES_KANBAN_WORKSPACES_ROOT python -m pytest tests/hermes_cli/test_kanban_db.py::test_connect_rejects_tls_record_in_sqlite_header tests/hermes_cli/test_kanban_db.py::test_init_db_refuses_corrupt_existing_file tests/hermes_cli/test_kanban_db.py::test_connect_refuses_corrupt_existing_file tests/hermes_cli/test_kanban_db.py::test_locked_healthy_db_does_not_classify_as_corrupt tests/hermes_cli/test_kanban_db.py::test_connect_falls_back_to_delete_on_locking_protocol tests/hermes_cli/test_kanban_db.py::test_add_column_if_missing_is_idempotent_on_race -q -o 'addopts='(6 passed)bad-boarddisk I/O failure and healthydefaulttick;/api/plugins/kanban/boardsreturnedbad-board.dispatch_status.state=quarantinedwithlast_error.kind=disk_io, whiledefault.dispatch_status.state=healthyNotes