fix: add cache subdirectories to MEDIA delivery safe roots - #33901
Closed
zhanglingfei112 wants to merge 1 commit into
Closed
fix: add cache subdirectories to MEDIA delivery safe roots#33901zhanglingfei112 wants to merge 1 commit into
zhanglingfei112 wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
Collaborator
zhanglingfei112
force-pushed
the
fix/media-delivery-cache-roots
branch
from
May 28, 2026 21:58
b701b64 to
c6a92cd
Compare
Contributor
|
Thanks for this — the fix is correct, but it's already on The issue was then reopened for a narrower case your PR doesn't cover: profile-scoped gateways with a symlinked Closing as already-implemented. Appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_b64_image() writes to cache/images/ but MEDIA_DELIVERY_SAFE_ROOTS only had image_cache. Add the five standard cache subdirs so MEDIA: tags pointing to valid generated files are not rejected.