feat: Honcho session pruning CLI (#33436) - #33893
Open
ousiaresearch wants to merge 1 commit into
Open
Conversation
…33436) Adds 'hermes honcho prune' CLI command with --dry-run, --force, and --include-active flags. Classifies sessions by age vs configured maxAgeDays (default 90), protects current session, and supports interactive confirmation. Adds prune_enabled and prune_max_age_days config fields to HonchoClientConfig.
alt-glitch
added
type/feature
Collaborator
6 tasks
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for splitting the Honcho pruning work out of the closed mega PR #33884. Current main still has no hermes honcho prune command (plugins/memory/honcho/cli.py:1760-1864), so the feature remains independently useful.
Problems
plugins/memory/honcho/cli.py:294-299:--forceis documented as confirmation bypass but also marks every undated session stale.hermes honcho prune --forcecan therefore delete sessions whose age was not established.plugins/memory/honcho/client.py:364-368: the new automatic-pruning fields are neither resolved byfrom_global_config()nor consumed by a gateway caller; the advertised startup/24-hour behavior is not implemented.- The diff changes no tests (
gh pr diff 33893 --name-only), leaving destructive classification and deletion paths uncovered.
Suggested changes
- Separate confirmation bypass from any override for unknown timestamps, and default unknown timestamps to retention.
- Remove or fully wire and test the automatic-pruning configuration.
- Add fake-SDK tests for dry run, timestamp boundaries, unknown timestamps, confirmation, and partial deletion failures.
Automated hermes-sweeper review.
| stale.append(entry) | ||
| elif age_days is None: | ||
| # No timestamp — too old to judge, skip unless --force | ||
| if force: |
Contributor
There was a problem hiding this comment.
--force is documented as skipping confirmation, but here it also makes an undated session eligible for deletion. Please retain sessions whose age cannot be established, or use a separate explicit override for that destructive behavior.
| # stray HONCHO_API_KEY env var. | ||
| explicitly_configured: bool = False | ||
|
|
||
| # Session pruning — automatic cleanup of stale Honcho sessions. |
Contributor
There was a problem hiding this comment.
These fields are not populated by from_global_config() and this PR adds no gateway startup/periodic caller. Please either wire the documented automatic-pruning behavior end-to-end with tests or remove these unused fields from this manual-CLI PR.
teknium1
added
sweeper:risk-session-state
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
hermes honcho prunecommand to prune stale Honcho sessions older than configured max age.Fixes #33436
Type of Change
Changes Made
plugins/memory/honcho/cli.py: Addedcmd_prune()with --dry-run, --force, --include-active flags + command routing + argparse registrationplugins/memory/honcho/client.py: Addedprune_enabledandprune_max_age_daysto HonchoClientConfigHow to Test
hermes honcho prune --dry-runto previewhermes honcho prune --forceto executeChecklist