fix(api-server): require auth for /health/detailed - #33847
Closed
Dusk1e wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
|
Thanks for the focused security fix. This exact endpoint-authentication guarantee is already implemented on current
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change secures the detailed health endpoint by requiring bearer authentication on
/health/detailedwheneverAPI_SERVER_KEYis configured.It keeps
/healthpublic for basic liveness checks, updates the API server implementation to enforce the existing auth contract, aligns the regression test coverage with the intended behavior, and documents the distinction between the public and authenticated health endpoints.Testing
tests/gateway/test_api_server.py::TestHealthDetailedEndpoint::test_health_detailed_returns_ok— passedtests/gateway/test_api_server.py::TestHealthDetailedEndpoint::test_health_detailed_no_runtime_status— passedtests/gateway/test_api_server.py::TestHealthDetailedEndpoint::test_health_detailed_requires_auth_when_key_configured— passedtests/gateway/test_api_server.py::TestModelsEndpoint::test_models_requires_auth— passedtests/gateway/test_api_server.py::TestCapabilitiesEndpoint::test_capabilities_requires_auth_when_key_configured— passedtests/gateway/test_api_server.py::TestEndpointAuth::test_models_requires_auth— passedtests/gateway/test_api_server.py::TestEndpointAuth::test_health_does_not_require_auth— passedTest summary:
7 passed, 149 deselected