Skip to content

fix(feishu): allow ignoring all-hands mentions - #33775

Open
iainherd wants to merge 1 commit into
NousResearch:mainfrom
iainherd:fix/33723-feishu-ignore-mention-all
Open

fix(feishu): allow ignoring all-hands mentions#33775
iainherd wants to merge 1 commit into
NousResearch:mainfrom
iainherd:fix/33723-feishu-ignore-mention-all

Conversation

@iainherd

Copy link
Copy Markdown

Summary

  • add FEISHU_IGNORE_MENTION_ALL / feishu.ignore_mention_all so Feishu all-hands mentions can be ignored as bot triggers
  • preserve existing default @_all admission behavior and explicit bot mentions
  • document the new option in English and zh-Hans Feishu docs

Test plan

  • python -m pytest tests/gateway/test_feishu_bot_admission.py tests/gateway/test_config.py tests/gateway/test_feishu.py -q
  • git diff --check HEAD~1..HEAD

Closes #33723

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery platform/feishu Feishu / Lark adapter labels May 28, 2026

@teknium1 teknium1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused Feishu regression coverage. The premise is still present on current main: plugins/platforms/feishu/adapter.py:4331-4335 treats raw @_all as a self-mention, and the required-mention group gate consumes that result at plugins/platforms/feishu/adapter.py:4274-4275.

Problems

  • The runtime change targets gateway/platforms/feishu.py:4098, but commit 5600105478ffde29d7566b45421b100eaa29c4ef moved the adapter to plugins/platforms/feishu/adapter.py; this patch cannot affect the current adapter path.
  • Current Feishu-specific YAML handling belongs to _apply_yaml_config() in plugins/platforms/feishu/adapter.py:5624-5633, so the new setting needs to be carried through that plugin-owned configuration flow as part of the port.

Suggested changes

  • Port the setting through the current plugin's settings, application, and _mentions_self() paths (plugins/platforms/feishu/adapter.py:377-412, 1541-1635, and 4331-4345), and port the YAML handoff to _apply_yaml_config().
  • Preserve the submitted default/configured/explicit-bot-mention regression cases against the relocated adapter.

Automated hermes-sweeper review.

@@ -4093,7 +4098,7 @@ def _allow_group_message(
def _mentions_self(self, message: Any) -> bool:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adapter path was moved to plugins/platforms/feishu/adapter.py by 5600105478ffde29d7566b45421b100eaa29c4ef; please port this change to the plugin adapter, where current main's _mentions_self() is at lines 4331-4345.

@teknium1 teknium1 added sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have platform/feishu Feishu / Lark adapter sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add option to ignore @all/@everyone mentions in Feishu group chats

4 participants