fix(feishu): allow ignoring all-hands mentions - #33775
Open
iainherd wants to merge 1 commit into
Open
Conversation
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused Feishu regression coverage. The premise is still present on current main: plugins/platforms/feishu/adapter.py:4331-4335 treats raw @_all as a self-mention, and the required-mention group gate consumes that result at plugins/platforms/feishu/adapter.py:4274-4275.
Problems
- The runtime change targets
gateway/platforms/feishu.py:4098, but commit5600105478ffde29d7566b45421b100eaa29c4efmoved the adapter toplugins/platforms/feishu/adapter.py; this patch cannot affect the current adapter path. - Current Feishu-specific YAML handling belongs to
_apply_yaml_config()inplugins/platforms/feishu/adapter.py:5624-5633, so the new setting needs to be carried through that plugin-owned configuration flow as part of the port.
Suggested changes
- Port the setting through the current plugin's settings, application, and
_mentions_self()paths (plugins/platforms/feishu/adapter.py:377-412,1541-1635, and4331-4345), and port the YAML handoff to_apply_yaml_config(). - Preserve the submitted default/configured/explicit-bot-mention regression cases against the relocated adapter.
Automated hermes-sweeper review.
| @@ -4093,7 +4098,7 @@ def _allow_group_message( | |||
| def _mentions_self(self, message: Any) -> bool: | |||
Contributor
There was a problem hiding this comment.
This adapter path was moved to plugins/platforms/feishu/adapter.py by 5600105478ffde29d7566b45421b100eaa29c4ef; please port this change to the plugin adapter, where current main's _mentions_self() is at lines 4331-4345.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEISHU_IGNORE_MENTION_ALL/feishu.ignore_mention_allso Feishu all-hands mentions can be ignored as bot triggers@_alladmission behavior and explicit bot mentionsTest plan
python -m pytest tests/gateway/test_feishu_bot_admission.py tests/gateway/test_config.py tests/gateway/test_feishu.py -qgit diff --check HEAD~1..HEADCloses #33723