fix(codex): recover stream output after SDK null output - #33771
Closed
liran29 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Duplicate of merged #32963 — same Codex null-output stream recovery (TypeError guard on |
Contributor
|
Thanks for this — closing as already fixed on The Codex null-output crash (
Your fix targets the same path that's now hardened upstream, so there's nothing left to merge here. Your authorship is preserved in your branch; I'm crediting your report in the umbrella issue #33932 (now closed). Appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.completed.output = nullresponse.output_item.doneitems or streamed text deltas instead of failing the turnRoot Cause
The ChatGPT Codex backend can stream valid output items and then emit a terminal
response.completedevent whoseresponse.outputisnull. OpenAI SDK 2.24 raisesTypeError("'NoneType' object is not iterable")while parsing that terminal event, before Hermes reaches the existing empty-output recovery path.Test
venv/bin/python -m pytest tests/run_agent/test_run_agent_codex_responses.py -q