Skip to content

fix(process-registry): avoid background rewrite on env-based spawn - #33754

Closed
charzhou wants to merge 4 commits into
NousResearch:mainfrom
charzhou:codex/fix-docker-background-rewrite
Closed

fix(process-registry): avoid background rewrite on env-based spawn#33754
charzhou wants to merge 4 commits into
NousResearch:mainfrom
charzhou:codex/fix-docker-background-rewrite

Conversation

@charzhou

Copy link
Copy Markdown
Contributor

Summary

  • Avoid reapplying compound background rewrites in background wrappers.
  • Pass to env.execute so wrapper command is not rewritten into invalid syntax.
  • Treat missing PID/failed launch as failed spawn so we never report a fake running session.
  • Add registry-level regression tests for launch failure and rewrite bypass.

Testing

  • ........................................................................ [ 72%]
    ............................ [100%]
    100 passed in 2.24s

Result

@charzhou

Copy link
Copy Markdown
Contributor Author

Closed and recreated with clean history; old PR included unrelated previous commits due branch basis.

@charzhou charzhou closed this May 28, 2026
@alt-glitch alt-glitch added type/bug Something isn't working comp/tools Tool registry, model_tools, toolsets tool/terminal Terminal execution and process management P2 Medium — degraded but workaround exists labels May 28, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #33756 (same author's revised version of this fix). This PR was closed and superseded by #33756.

@alt-glitch alt-glitch added the duplicate This issue or pull request already exists label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists tool/terminal Terminal execution and process management type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants