Skip to content

fix: accept responses as alias for codex_responses in api_mode config #33637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kailigithub wants to merge 1 commit into from
+5 −0
Closed

fix: accept responses as alias for codex_responses in api_mode config #33637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hermes_cli/runtime_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,11 @@ def _parse_api_mode(raw: Any) -> Optional[str]:
"""Validate an api_mode value from config. Returns None if invalid."""
if isinstance(raw, str):
normalized = raw.strip().lower()
# Alias: "responses" is accepted as a shorthand for "codex_responses"
# so that api_mode: responses in config.yaml behaves identically to
# selecting option 3 in `hermes setup`.
if normalized == "responses":

@teknium1 teknium1 Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a resolver-level regression for a named providers: or custom_providers: entry using api_mode: responses. In current main, bare non-OpenAI provider: custom routes deliberately discard the resulting codex_responses mode (_resolve_plain_custom_api_mode()), so a parser-only check would not verify the supported configuration path.

return "codex_responses"
if normalized in _VALID_API_MODES:
return normalized
return None
Expand Down
Loading