Repository navigation
Conversation
Closed
1 task
|
Superseded by #43236 (merged,
#43236 uses the existing planned-stop marker primitive (rather than inferring intent from the signal) and is verified end-to-end against a real Thanks for the fix here — the approach matched; it just landed via #43236 first. One residual your PR also touched: writing the marker on the s6 restart path (not just stop). I'm tracking that as a follow-up to fold into the restart path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33597
Summary
runningingateway_state.jsonwhen the gateway is torn down by an unexpected signal such as container restartstopandrestartso explicit user actions still persiststoppedTesting
uv run --frozen pytest -o addopts= tests/gateway/test_clean_shutdown_marker.py tests/hermes_cli/test_service_manager.py\n-uv run --frozen ruff check gateway/run.py gateway/status.py hermes_cli/service_manager.py tests/gateway/test_clean_shutdown_marker.py tests/hermes_cli/test_service_manager.py\n-git diff --check