Skip to content

fix(cron): skip idle config loads in scheduler tick #33612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LeonSGP43 wants to merge 1 commit into from
+16 −2
Closed

fix(cron): skip idle config loads in scheduler tick #33612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cron/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1889,8 +1889,9 @@ def tick(verbose: bool = True, adapters=None, loop=None) -> int:
try:
due_jobs = get_due_jobs()

if verbose and not due_jobs:
logger.info("%s - No jobs due", _hermes_now().strftime('%H:%M:%S'))
if not due_jobs:

@teknium1 teknium1 Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current main added an idle-path MCP orphan sweep after this PR branched (cron/scheduler.py:3735-3780). Returning here would skip that cleanup on every idle verbose=False gateway tick; preserve the sweep while avoiding load_config().

if verbose:
logger.info("%s - No jobs due", _hermes_now().strftime('%H:%M:%S'))
return 0

if verbose:
Expand Down
13 changes: 13 additions & 0 deletions tests/cron/test_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2584,3 +2584,16 @@ def fake_run_coro(coro, _loop):
# 2. Second file still got dispatched — one timeout doesn't abort the batch
adapter.send_video.assert_called_once()
assert adapter.send_video.call_args[1]["video_path"] == str(fast.resolve())


def test_tick_skips_config_load_when_no_jobs_due(tmp_path):
"""Idle cron ticks should return before config/home churn."""
from cron import scheduler as sched

with patch("cron.scheduler._hermes_home", tmp_path), \
patch("cron.scheduler.get_due_jobs", return_value=[]), \
patch("cron.scheduler.load_config") as mock_load_config:
result = sched.tick(verbose=False)

assert result == 0
mock_load_config.assert_not_called()
Loading