Skip to content

fix: parse yolo status env consistently - #33607

Closed
denisqq wants to merge 1 commit into
NousResearch:mainfrom
denisqq:fix/yolo-status-bar-truthy
Closed

fix: parse yolo status env consistently#33607
denisqq wants to merge 1 commit into
NousResearch:mainfrom
denisqq:fix/yolo-status-bar-truthy

Conversation

@denisqq

@denisqq denisqq commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Parse HERMES_YOLO_MODE in the CLI status bar with is_truthy_value(...) instead of raw string truthiness.
  • Add regression coverage for false-like and truthy YOLO env values in both status-bar text and prompt-toolkit fragments.

Closes #33605

Test Plan

  • python -m pytest tests/cli/test_cli_status_bar.py tests/test_utils_truthy_values.py tests/tools/test_yolo_mode.py::TestYoloMode::test_false_like_yolo_values_do_not_bypass_dangerous_command -q -o 'addopts='

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists labels May 28, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing fix with #33614 for #33605 — both replace bool(os.getenv("HERMES_YOLO_MODE")) with is_truthy_value(...) in _build_status_bar_text and _get_status_bar_fragments. Tests in different files (test_cli_status_bar.py vs test_cli_background_status_indicator.py). Recommend consolidating into a single PR.

@denisqq

denisqq commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Closing because this PR targeted the wrong issue. Replaced by #33620 for the actual /goal compression-session migration bug.

@denisqq denisqq closed this May 28, 2026
@denisqq
denisqq deleted the fix/yolo-status-bar-truthy branch May 28, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI status bar treats HERMES_YOLO_MODE=false as YOLO enabled

2 participants