Fix Kanban DB write safety and JSON error handling - #33491
Open
ha001985 wants to merge 1 commit into
Open
Conversation
ha001985
force-pushed
the
fix/kanban-db-stability
branch
from
May 27, 2026 22:00
b1c4f66 to
96aa509
Compare
Collaborator
Author
Thanks for the context. I’m happy to consolidate with #33325 / #32759 and align this PR with the preferred direction. This PR overlaps on busy_timeout, but it also includes a few additional pieces that may be useful for the final consolidated fix:
Validation performed locally:
Please let me know whether you’d prefer:
|
ha001985
force-pushed
the
fix/kanban-db-stability
branch
from
May 28, 2026 05:57
96aa509 to
97cc148
Compare
…t_lock and _sqlite_connect for busy_timeout
ha001985
force-pushed
the
fix/kanban-db-stability
branch
from
May 28, 2026 06:56
97cc148 to
64db74d
Compare
Contributor
|
Thanks for the detailed validation and for offering to consolidate with the related write-safety PRs. Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds busy_timeout lock-contention mitigation, write_txn depth tracking keyed by connection/thread, per-board write serialization, corrupt/init JSON handling so Desktop does not get empty stdout, and preserves the
list --jsonarray contract.Changes
list --jsoncatches corrupt/invalid JSON and falls back gracefully instead of emitting empty stdoutlist --jsonalways returns a JSON array (never empty, never malformed)Tests
Validation
Live validation was run on a fresh test board
kanban-postfix-validationwith the following results:hermes kanban list --jsonreturned valid JSON with correct status breakdown (ready=10, todo=2, done=2, blocked=1)PRAGMA integrity_checkreturnedokat every phaseBreaking changes
None. The Kanban board is backwards-compatible with existing data. Gateway auto-dispatch remains disabled by default (HERMES_KANBAN_DISPATCH_IN_GATEWAY=0) as the correct production default.