fix(cron): gate skip_memory on memory_search in enabled_toolsets

[fayenix]

Problem

Cron jobs with skip_memory=True silently block memory_search from all cron job sessions. This prevents cron-based workflows from accessing MemOS traces — even when the cron job explicitly includes "memory_search" in its enabled_toolsets.

Root Cause

In cron/scheduler.py, skip_memory=True is hardcoded for all cron jobs. The comment says "Cron system prompts would corrupt user representations" but this blanket approach breaks any cron job that needs memory access.

Fix

Gate skip_memory on whether "memory_search" is in the job's explicit enabled_toolsets:

# Before:
skip_memory=True,  # all cron jobs, always

# After:
skip_memory="memory_search" not in (_cron_toolsets or []),

The sentinel "memory_search" (rather than "memory") is intentional — "memory_search" never appears in default platform toolsets, so all default cron jobs keep skip_memory=True. Only jobs that explicitly opt in via enabled_toolsets: ["memory_search"] get skip_memory=False.

Testing

• Verified across multiple Hermes instances running MemOS
• Cron jobs with memory_search in toolsets now surface MemOS traces
• Default cron jobs unaffected

[teknium1]

Thanks for targeting a verified cron memory-provider gap.

Problems

• cron/scheduler.py:2045 in this diff checks memory_search, but cron's enabled_toolsets field contains toolset names (cron/jobs.py:1078). The provider gate accepts memory or a composite resolving to it (agent/memory_manager.py:82-116), and unknown toolsets resolve to no schemas (model_tools.py:367-388). Consequently, ["memory"] still leaves skip_memory=True, while ["memory_search"] is not a standard usable opt-in.
• This change also enables the full provider lifecycle rather than only search: completed turns call MemoryManager.sync_all() (run_agent.py:3403-3424). The current cron default explicitly protects user representations (cron/scheduler.py:3073), so the desired write/sync policy needs to be explicit.

Suggested changes

• Base the opt-in on the established memory toolset and preserve the default-off behavior. Choose and document whether job-level selection, cron-platform configuration, or a separate persisted opt-in is required.
• Add scheduler tests for default behavior and the supported explicit opt-in path.

Automated hermes-sweeper review.

[teknium1]

Closing as superseded by PR #91447 (merged as ef04d84) — the toolset-gated approach is no longer needed since cron now passes skip_memory=False unconditionally and the memory toolset denial was removed entirely. Thanks @fayenix.