fix: set HOME for profile gateway services - #33370
Closed
akropp wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks for the catch — #33481 lands the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When a per-profile gateway runs under s6 in the Docker container, the generated service script drops privileges with
s6-setuidgid hermesbut can still inheritHOME=/root. Code paths that resolve state/cache paths throughPath.home()or XDG defaults may then attempt to write under/root, causing permission errors for the hermes user. The container main wrapper already normalizes HOME; profile gateway service scripts should do the same.Test Plan
python -m pytest tests/hermes_cli/test_service_manager.py -qpython -m ruff check hermes_cli/service_manager.py tests/hermes_cli/test_service_manager.py