docs(i18n): sync API server discovery surfaces - #33283
Conversation
|
Thanks for documenting these externally consumable API surfaces. Current main already has a more detailed English implementation of the endpoint documentation, so the English portion needs a targeted salvage rather than a direct application. Problems
Suggested changes
Automated hermes-sweeper review. |
067950a to
8bf0438
Compare
|
Reworked per the salvage guidance:
I verified the flags and all registered routes from |
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Two PRs touch the API-server documentation, but they address different causes: #33283 synchronizes capability discovery and missing zh-Hans session/skills documentation, while #62216 attempted comma-separated API-server master keys across authentication code, configuration, and docs.
Related pull requests
- #33283
related— (+59/-2) — merge: The revised diff follows the contributor’s keep_open salvage guidance by preserving the richer English endpoint sections, adding the five live capability flags to both examples, and filling the missing zh-Hans Sessions API and skills/toolsets coverage. - #62216 [closed]
related— (+58/-13) — keep closed: Despite the earlier keep_open review on #62216, the diff drops blank key segments, leaves tests referencing the removed_api_key, and would regress newer encoded-bytes and fail-closed authentication work; the later contributor decision also documents that multiplicity belongs in scoped credential-pool/token designs tracked by #44615 and #64697, not comma-separated equivalent master keys.
Suggested consolidation
Merge #33283 as the targeted, review-aligned documentation synchronization. Keep #62216 closed rather than treating it as a duplicate: it addresses a separate authentication design, has concrete correctness and regression issues, and conflicts with the documented repository direction toward scoped credentials.
Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 12 kB of PR diffs, 2 kB of issue/PR text, 4 kB of discussion (6 comments), 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
Summary
/v1/capabilitiesJSON examples with the liveskills_apiand foursession_*feature flagsThe localized Sessions API table covers all nine registered routes, plus fork/chat examples, capability discovery, inline-image support, and the read-only skills/toolsets endpoints.
Validation
trueingateway/platforms/api_server.py/api/sessionsroutes and both/v1/skills//v1/toolsetsregistrationsgit diff --checkDocs-only change; server behavior is unchanged. This is the targeted salvage requested in the maintainer review.