fix: patch Responses API parse_response to handle empty/None output field - #33275
Closed
alvinycheung wants to merge 1 commit into
Closed
fix: patch Responses API parse_response to handle empty/None output field#33275alvinycheung wants to merge 1 commit into
alvinycheung wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
Collaborator
|
Late duplicate of merged #32963 which already fixes the Codex response.output=None TypeError. Monkey-patching the SDK is unnecessary — the canonical fix uses except TypeError recovery in codex_runtime.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
TypeError: 'NoneType' object is not iterablein theopenaiSDK when utilizing Codex/Responses backends whereresponse.outputis returned asNone(for instance, on the finalresponse.completedevent).We apply a runtime monkey-patch to
openai.lib._parsing._responses.parse_responseinside_load_openai_cls()to defaultresponse.outputto[]whenNone, preventing the crash.