fix: preserve Ctrl+J newlines in Ghostty - #33193
Closed
seppegadeyne wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
Author
|
Thanks for the pointer — I missed the existing issue/competing PRs before opening this. Sorry for the duplicate review noise. I agree this overlaps with #9299 and the open Ctrl+J/newline PRs (#25111, #22911, #26086, #27688). The only intended extra scope in this PR is:
I don’t want to fragment the review further. Maintainers, what would you prefer?
Unless there’s a preference to keep this separate, I’m happy to close this and transfer the unique Ghostty/TUI bits to the canonical thread. |
teknium1
added a commit
that referenced
this pull request
May 29, 2026
Required by CI author validation after salvaging PR #33193.
KKT-OPT
pushed a commit
to KKT-OPT/hermes-agent
that referenced
this pull request
May 31, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
Required by CI author validation after salvaging PR #33193.
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 25, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
donbowman
pushed a commit
to donbowman/hermes-agent
that referenced
this pull request
Jul 13, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
Required by CI author validation after salvaging PR NousResearch#33193.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
venv/bin/python -m pytest tests/cli/test_ctrl_enter_newline.py tests/cli/test_cli_init.py -q→ 52 passednpm test -- src/__tests__/textInputPassThrough.test.tsinui-tui/→ 6 passedNotes