feat(feishu): convert markdown tables to interactive card elements - #33180
Closed
whatwoods wants to merge 1 commit into
Closed
feat(feishu): convert markdown tables to interactive card elements#33180whatwoods wants to merge 1 commit into
whatwoods wants to merge 1 commit into
Conversation
Collaborator
Closed
2 tasks
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tackling a real Feishu rendering limitation. Current main still routes markdown tables to plain text in plugins/platforms/feishu/adapter.py:4524-4530, so the underlying problem remains.
Problems
- The PR deletes the unrelated OpenClaw migration skill and script. They are active bundled dependencies:
hermes_cli/claw.py:37-43,hermes_cli/setup.py:2349-2355, andtests/skills/test_openclaw_migration.py:9-24reference the script. - The feature targets
gateway/platforms/feishu.py, but current main moved the live adapter toplugins/platforms/feishu/adapter.pyin560010547. - The new
interactivepath would not use the existing API-rejection text fallbacks, which are restricted topostinplugins/platforms/feishu/adapter.py:1913-1936and1963-1971.
Suggested changes
- Port only the table-card work to
plugins/platforms/feishu/adapter.py; keep the migration skill intact. - Cover pure/mixed/multiple tables and interactive send/edit rejection fallback in
tests/gateway/test_feishu.py.
Automated hermes-sweeper review.
whatwoods
force-pushed
the
feat/feishu-table-to-card
branch
from
July 18, 2026 05:21
4ada75e to
e2b179d
Compare
Author
|
Reworked in e2b179d to address the sweeper review:
Validation: Feishu 217/217, OpenClaw migration 41/41, Ruff and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Feishu post-type
mdelements cannot render markdown tables. The existing outbound path therefore downgraded table-bearing replies to plain text, leaving structured data as raw pipe-delimited text.Solution
Markdown tables are now converted to Feishu Card JSON 2.0
tableelements and sent asinteractivemessages. Surrounding prose remains ordered card markdown.Changes
lark_mdcellsplugins/platforms/feishu/adapter.pyimplementationBefore / After
Before: Table content was sent as plain text:
After: It renders as a structured Feishu table inside an interactive card.
Testing
scripts/run_tests.sh tests/gateway/test_feishu.py -q— 217 passedscripts/run_tests.sh tests/skills/test_openclaw_migration.py -q— 41 passed.venv/bin/ruff check plugins/platforms/feishu/adapter.py tests/gateway/test_feishu.py— passedgit diff --check— passed