Skip to content

fix: omit empty tools for Codex Responses - #33015

Closed
roycepersonalassistant wants to merge 1 commit into
NousResearch:mainfrom
roycepersonalassistant:fix/codex-responses-omit-empty-tools
Closed

fix: omit empty tools for Codex Responses#33015
roycepersonalassistant wants to merge 1 commit into
NousResearch:mainfrom
roycepersonalassistant:fix/codex-responses-omit-empty-tools

Conversation

@roycepersonalassistant

Copy link
Copy Markdown
Contributor

Summary

  • omit the Responses API tools kwarg when no converted tools are available
  • keep tool_choice and parallel_tool_calls gated on actual tools
  • add regression coverage for tools=None

Test plan

  • ./scripts/run_tests.sh tests/agent/transports/test_codex_transport.py
  • ./scripts/run_tests.sh tests/run_agent/test_run_agent_codex_responses.py tests/run_agent/test_413_compression.py tests/agent/transports/test_codex_transport.py
  • git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint provider/copilot GitHub Copilot (ACP + Chat) codex labels May 27, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks — closing as already fixed on main.

The tools=None TypeError on openai-codex when no tools are registered is resolved by fc47b7285 (omit the tools key entirely from Codex Responses kwargs when empty) plus 68d547281 / #3820 (omit tools instead of sending None). Both are on main.

Your fix targets the same already-hardened path. Authorship stays in your branch; crediting your report in the umbrella issue #33932. Appreciate it.

@teknium1 teknium1 closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have provider/copilot GitHub Copilot (ACP + Chat) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants