Skip to content

fix: clean Mattermost progress breadcrumbs - #33012

Open
admin-prodesign wants to merge 1 commit into
NousResearch:mainfrom
admin-prodesign:fix/mattermost-progress-cleanup
Open

fix: clean Mattermost progress breadcrumbs#33012
admin-prodesign wants to merge 1 commit into
NousResearch:mainfrom
admin-prodesign:fix/mattermost-progress-cleanup

Conversation

@admin-prodesign

Copy link
Copy Markdown

Summary\n- add Mattermost post deletion support so cleanup_progress can remove temporary progress/status bubbles\n- sanitize noisy provider retry/fallback errors for Mattermost like Telegram\n- cover Mattermost cleanup and provider-noise behavior with focused tests\n\n## Tests\n- python -m pytest tests/gateway/test_telegram_noise_filter.py::test_mattermost_status_suppresses_retry_noise tests/gateway/test_telegram_noise_filter.py::test_mattermost_status_sanitizes_raw_provider_errors tests/gateway/test_telegram_noise_filter.py::test_mattermost_final_response_sanitizes_raw_provider_errors tests/gateway/test_mattermost.py::TestMattermostSend::test_delete_message_calls_api_delete tests/gateway/test_mattermost.py::TestMattermostSend::test_delete_message_failure_returns_false -q -o 'addopts='\n

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery labels May 27, 2026
@admin-prodesign
admin-prodesign force-pushed the fix/mattermost-progress-cleanup branch from 9fd7cc0 to cf14825 Compare May 27, 2026 04:07
@teknium1 teknium1 added sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 13, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused Mattermost cleanup work. The deletion support addresses a current gap: gateway/run.py:17233-17238 disables cleanup_progress unless an adapter overrides delete_message, and plugins/platforms/mattermost/adapter.py currently has no such override.

Problems

  • The gateway/run.py sanitizer hunk is now superseded. Current main sanitizes all human-facing gateway platforms through gateway/run.py:94-107 and gateway/run.py:414-457; Mattermost is already covered, with parametrized coverage in tests/gateway/test_telegram_noise_filter.py:13-75. Preserve that broader behavior rather than restoring a Telegram/Mattermost-only gate.
  • The timeline-linked fix(mattermost): classify API errors, escalate fatals, lock single-instance, surface audio/slash attachments #35645 identifies an overlapping Mattermost edit_message rewrite, so its adapter changes and this deletion support need manual reconciliation if both are salvaged.

Suggested changes

  • Retain the Mattermost DELETE implementation and its focused tests, adapted to the current adapter structure; drop the superseded sanitizer/test portion.

Automated hermes-sweeper review.

@admin-prodesign
admin-prodesign force-pushed the fix/mattermost-progress-cleanup branch from cf14825 to 42556f7 Compare July 14, 2026 06:58
@admin-prodesign

Copy link
Copy Markdown
Author

Addressed the sweeper review in 42556f7:

Verification:

  • 272 passed for tests/gateway/test_mattermost.py and tests/gateway/test_telegram_noise_filter.py
  • Ruff clean on the changed adapter/test files
  • git diff --check clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-message-delivery Sweeper risk: may drop, duplicate, misroute, or suppress messages sweeper:risk-security-boundary Sweeper risk: may affect sandboxing, auth, credentials, or sensitive data type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants