fix: clean Mattermost progress breadcrumbs - #33012
Open
admin-prodesign wants to merge 1 commit into
Open
Conversation
admin-prodesign
force-pushed
the
fix/mattermost-progress-cleanup
branch
from
May 27, 2026 04:07
9fd7cc0 to
cf14825
Compare
Contributor
|
Thanks for the focused Mattermost cleanup work. The deletion support addresses a current gap: Problems
Suggested changes
Automated hermes-sweeper review. |
admin-prodesign
force-pushed
the
fix/mattermost-progress-cleanup
branch
from
July 14, 2026 06:58
cf14825 to
42556f7
Compare
Author
|
Addressed the sweeper review in 42556f7:
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add Mattermost post deletion support so cleanup_progress can remove temporary progress/status bubbles\n- sanitize noisy provider retry/fallback errors for Mattermost like Telegram\n- cover Mattermost cleanup and provider-noise behavior with focused tests\n\n## Tests\n- python -m pytest tests/gateway/test_telegram_noise_filter.py::test_mattermost_status_suppresses_retry_noise tests/gateway/test_telegram_noise_filter.py::test_mattermost_status_sanitizes_raw_provider_errors tests/gateway/test_telegram_noise_filter.py::test_mattermost_final_response_sanitizes_raw_provider_errors tests/gateway/test_mattermost.py::TestMattermostSend::test_delete_message_calls_api_delete tests/gateway/test_mattermost.py::TestMattermostSend::test_delete_message_failure_returns_false -q -o 'addopts='\n