Skip to content

fix(codex): recover streams with null output - #32945

Closed
mioimotoai-lgtm wants to merge 2 commits into
NousResearch:mainfrom
mioimotoai-lgtm:fix/codex-null-output-recovery
Closed

fix(codex): recover streams with null output#32945
mioimotoai-lgtm wants to merge 2 commits into
NousResearch:mainfrom
mioimotoai-lgtm:fix/codex-null-output-recovery

Conversation

@mioimotoai-lgtm

Copy link
Copy Markdown
Contributor

Summary

  • recover Codex Responses streams when the backend sends response.output = null
  • backfill streamed output items or synthesize assistant text from streamed deltas
  • apply the same recovery path to auxiliary Codex calls
  • add regression coverage for SDK NoneType iteration failures and direct null final output

Test Plan

  • pytest tests/agent/test_codex_runtime_null_output.py -q
  • hermes -z '只回答 OK' --provider openai-codex --model gpt-5.5

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint codex provider/openai OpenAI / Codex Responses API duplicate This issue or pull request already exists labels May 27, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #32884 — same Codex null output recovery (backfill streamed items, synthesize text from deltas). Also covers auxiliary_client.py. Root cause: #11179.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as duplicate — the Codex null-output fix has been merged via #32963 (cherry-picked from @carltonawong's PR #32890, the one Gille reviewed). Thanks for jumping on the outage so quickly; appreciate the help. Closes #11179.

@teknium1 teknium1 closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have provider/openai OpenAI / Codex Responses API type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants