Update here.now optional skill to 1.19.0 - #32889
Conversation
037bac6 to
dcb8d08
Compare
|
Refreshed this PR to the current here.now skill release (1.16.0), which adds Site access control guidance. Scripts are unchanged from the last push and pass bash -n. Would appreciate a review when someone has a chance — happy to adjust anything needed to land it. |
teknium1
left a comment
There was a problem hiding this comment.
Thanks for refreshing the optional skill and adding the Site access-control guidance. Current main is still at 1.15.3 in optional-skills/productivity/here-now/SKILL.md:4, so this remains useful work.
Problems
- The new frontmatter description at
optional-skills/productivity/here-now/SKILL.md:3is multi-sentence and far beyond the hardline limit.AGENTS.md:888-892requires modernized skills to use one sentence, no more than 60 characters, ending with a period. - The helper changes remove the existing
--forkableand fork-meta behavior and change the anonymous-only claim-token guards currently present atoptional-skills/productivity/here-now/scripts/publish.sh:108-110and:264-269. The statedbash -nchecks cover syntax, not these request-body compatibility changes.
Suggested changes
- Compress the frontmatter description; keep the trigger phrases and access-control detail in the skill body/tags.
- Add
tests/skills/test_here_now_skill.pyfor frontmatter and intended publish payload behavior, including the API-key/claim-token case and the intended replacement for--forkable.
This is an automated hermes-sweeper review.
| @@ -1,15 +1,27 @@ | |||
| --- | |||
| name: here.now | |||
| description: Publish static sites to {slug}.here.now and store private files in cloud Drives for agent-to-agent handoff. | |||
| version: 1.15.3 | |||
| description: > | |||
There was a problem hiding this comment.
AGENTS.md:888-892 requires a modernized skill description to be one sentence, at most 60 characters, and end with a period. Please reduce this listing description and retain the detailed trigger phrases in the body or tags.
There was a problem hiding this comment.
Done — description is now Publish sites to live URLs and store files in cloud Drives. (59 chars, one sentence). Trigger phrases moved to a "When to use" section in the body; tags unchanged. Enforced going forward by the new tests/skills/test_here_now_skill.py.
|
Thanks for the review — all points addressed in the latest push, which also bumps the skill to the current release (1.17.0):
|
Adds workspace publishing (publish.sh --workspace sends the x-herenow-account selector on create/update and finalize and reports the team URL as publish_result.account_url), documents workspace access modes, and refreshes the skill body from the 1.18.0 upstream bundle. Tests cover the new selector behavior alongside the existing claim-token and no-forkable assertions. Co-authored-by: Cursor <cursoragent@cursor.com>
4d787b6 to
b7abe3e
Compare
… unrelated to this skill-only diff) Co-authored-by: Cursor <cursoragent@cursor.com>
|
CI note: the failing job is |
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # optional-skills/productivity/here-now/SKILL.md
Skill content: adds Site version history — every publish records an immutable version; agents can list history, preview past versions at owner-only URLs, and restore instantly (docs: https://here.now/docs#versions). publish.sh fixes: - Exclude .herenow/state.json from directory collection. The script writes this local state cache itself and previously uploaded it as site content; for anonymous sites it contains the claim token. - Replace `seq 0 $((UPLOAD_COUNT - 1))` with a C-style loop. BSD/macOS seq counts DOWN for `seq 0 -1`, so a republish where every file was unchanged (zero uploads) iterated twice with null paths and died between create and finalize, stranding the site in status=pending. Tests: two new cases in test_here_now_skill.py covering both behaviors (state.json excluded from the create manifest; zero-upload republish reaches finalize). All 15 pass locally; scripts pass bash -n.
|
Refreshed to the current here.now skill release (1.19.0). Two things in this push beyond the routine version bump: Two
Skill content: adds Site version history — every publish records an immutable version, with list/preview/restore endpoints (docs). Per this repo's testing standard, |
Summary
Updates the
official/productivity/here-nowoptional skill from 1.15.3 to 1.18.0, matching the current upstream bundle (https://github.com/heredotnow/skill):publish.sh --workspace <subdomain>publishes into a shared team account — the Site belongs to the workspace, serves at{label}.{workspace}.here.now, and the script reports the team URL aspublish_result.account_url. The selector is sent as anx-herenow-accountheader on create/update and finalize; the flag requires an API key and is rejected in combination with--from-drive.restricted), adds a "Publish to a workspace" section, and refreshes docs-reading guidance.description≤ 60 chars; the trigger-phrase list lives in the "When to use" body section.tests/skills/test_here_now_skill.pycovering the frontmatter standard, claim-token request-body behavior (anonymous and API-key updates), the removed--forkable/fork-meta surface, and the new workspace selector behavior.Test plan
python -m pytest tests/skills/test_here_now_skill.py— 13 passedbash -nonpublish.shanddrive.sh