fix(cron): release tick lock before running jobs - #32786
Closed
Ordinath wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Closing this PR for now. Opened prematurely during local diagnosis; will revisit only if/when there is explicit agreement on the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tick.lockafter selecting due jobs and advancingnext_run_atWhy
A long-running or wedged cron job can currently hold
~/.hermes/cron/.tick.lockfor the entire job runtime. Later ticks return0with the lock held, so unrelated due jobs and smoke tests stay stuck behind the slow job.This reproduces the scheduler wedge described in #3752 and matches the lock-scope bug discussed in #27492 / #29350.
Test plan
uv run pytest tests/cron/test_scheduler.py::TestParallelTick -q -o addopts=''Result:
4 passed in 1.33s