feat: infer goal turn budgets up to 250 - #32536
Open
unreliable-machine wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the contribution. The premise is still live: current main assigns each goal the configured fixed budget in Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Treat goals.max_turns as a ceiling capped at 250 instead of a fixed budget for every /goal.\n- Infer per-goal budgets from prompt complexity: simple goals keep 20 turns; complex plan-style or explicit persistence prompts scale up automatically.\n- Update CLI/gateway config handling, docs, and focused goal tests.\n\n## Tests\n- python -m pytest -o 'addopts=' tests/hermes_cli/test_goals.py tests/gateway/test_goal_max_turns_config.py tests/tui_gateway/test_goal_command.py -q\n- python -m py_compile hermes_cli/goals.py cli.py gateway/run.py hermes_cli/config.py\n- Manual heuristic assertions for simple, complex, and explicit-turn prompts\n