[codex] fix(web): honor registered provider availability - #32465
Closed
stardust-mem wants to merge 1 commit into
Closed
[codex] fix(web): honor registered provider availability#32465stardust-mem wants to merge 1 commit into
stardust-mem wants to merge 1 commit into
Conversation
stardust-mem
marked this pull request as ready for review
May 26, 2026 12:38
This was referenced May 27, 2026
stardust-mem
force-pushed
the
codex/web-provider-registry-availability
branch
from
June 9, 2026 06:43
48d3784 to
8b80409
Compare
Collaborator
|
Superseded by #57779, which fixes this same bug class (plugin-registered web providers invisible to the tool-availability gate) as a single chokepoint in Your PR targeted the same gate and informed the approach — thanks for the contribution, credited in the merged PR body. Closing as superseded. #57779 |
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31873 by letting the web tool availability gate recognize provider names registered through
agent.web_search_registryinstead of only accepting the built-in backend list.Changes
_get_backend()when they are present in the registry.is_available()method.check_web_api_key()consider configuredweb.backend,web.search_backend, andweb.extract_backendprovider names before falling back to legacy built-in auto-detection.kagiprovider proving custom providers can exposeweb_search/web_extract, and that unavailable explicit custom providers do not silently fall back to another backend.Validation
pytest tests/tools/test_web_tools_config.py::TestBackendSelection tests/tools/test_web_tools_config.py::TestCheckWebApiKey -qpytest tests/tools/test_web_providers.py tests/tools/test_web_providers_brave_free.py tests/tools/test_web_providers_ddgs.py tests/tools/test_web_providers_searxng.py tests/tools/test_web_providers_xai.py tests/plugins/web/test_web_search_provider_plugins.py -qpytest tests/tools/test_web_tools_config.py -qpython -m py_compile tools/web_tools.pygit diff --check