fix(compression): mark pruned skill_view summaries (#32106) - #32375
Open
LeonSGP43 wants to merge 1 commit into
Open
fix(compression): mark pruned skill_view summaries (#32106)#32375LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
Contributor
|
Hi @LeonSGP43, great work on this. I just left a note on #32562 proposing we merge our approaches: your tests + my prompt_builder P1 rule = a complete P0+P1 fix for #32106.> |
dolphin-creator
added a commit
to dolphin-creator/JBO-Agent
that referenced
this pull request
May 29, 2026
…coverage (NousResearch#32106) - TestToolResultSummaries: skill_view emits [SKILL_PRUNED], skills_list/skill_manage remain metadata-only - TestGuidanceConstants: SKILLS_GUIDANCE includes ## Skill Safety Rule with reload instruction - Credits: test patterns from LeonSGP43 (PR NousResearch#32375), adapted for merged PR
Contributor
|
Hey @LeonSGP43 — I've incorporated your test patterns from #32375 into my PR #32562 (commit b7aaf2a), with full credit in the commit message. The combined PR now covers both:
Since #32562 now supersedes the test coverage from #32375, would you be comfortable with closing #32375? Your contribution is credited in the merged commit. If you have any concerns, happy to adjust! |
Contributor
|
Thanks for the focused P0 fix. Current The added helper-level tests directly cover the changed summary contract. The helper and test module have moved since the PR branch, but the current implementation retains the same focused integration point, so salvage should be localized. Automated hermes-sweeper review. |
teknium1
added
sweeper:blast-contained
teknium1
added a commit
that referenced
this pull request
Jul 23, 2026
…tected prune, real-compress survival 21 tests pinning the salvaged #44166 behavior: - marker emit + extractor round trip (patterns adapted from PR #32375 by @LeonSGP43, with credit) - no-duplicate re-injection when the canonical marker survived (the original PR's presence-check defect) - Phase-1 protection for just-loaded / user-referenced skills, and the Pass-4 pressure override that keeps #61932 fixed - deterministic marker survival through a REAL compress() with a mocked aux LLM: drop → re-injected, keep → not duplicated, static-fallback path, iterative re-compression via rehydrated handoff - markers never classify as handoff content (classify_summary_content / _strip_context_summary_handoff_message untouched) - SKILLS_GUIDANCE Skill Safety Rule renders with real newlines
teknium1
added a commit
that referenced
this pull request
Jul 23, 2026
…tected prune, real-compress survival 21 tests pinning the salvaged #44166 behavior: - marker emit + extractor round trip (patterns adapted from PR #32375 by @LeonSGP43, with credit) - no-duplicate re-injection when the canonical marker survived (the original PR's presence-check defect) - Phase-1 protection for just-loaded / user-referenced skills, and the Pass-4 pressure override that keeps #61932 fixed - deterministic marker survival through a REAL compress() with a mocked aux LLM: drop → re-injected, keep → not duplicated, static-fallback path, iterative re-compression via rehydrated handoff - markers never classify as handoff content (classify_summary_content / _strip_context_summary_handoff_message untouched) - SKILLS_GUIDANCE Skill Safety Rule renders with real newlines
teknium1
added a commit
that referenced
this pull request
Jul 23, 2026
…tected prune, real-compress survival 21 tests pinning the salvaged #44166 behavior: - marker emit + extractor round trip (patterns adapted from PR #32375 by @LeonSGP43, with credit) - no-duplicate re-injection when the canonical marker survived (the original PR's presence-check defect) - Phase-1 protection for just-loaded / user-referenced skills, and the Pass-4 pressure override that keeps #61932 fixed - deterministic marker survival through a REAL compress() with a mocked aux LLM: drop → re-injected, keep → not duplicated, static-fallback path, iterative re-compression via rehydrated handoff - markers never classify as handoff content (classify_summary_content / _strip_context_summary_handoff_message untouched) - SKILLS_GUIDANCE Skill Safety Rule renders with real newlines
teknium1
added a commit
that referenced
this pull request
Jul 23, 2026
…tected prune, real-compress survival 21 tests pinning the salvaged #44166 behavior: - marker emit + extractor round trip (patterns adapted from PR #32375 by @LeonSGP43, with credit) - no-duplicate re-injection when the canonical marker survived (the original PR's presence-check defect) - Phase-1 protection for just-loaded / user-referenced skills, and the Pass-4 pressure override that keeps #61932 fixed - deterministic marker survival through a REAL compress() with a mocked aux LLM: drop → re-injected, keep → not duplicated, static-fallback path, iterative re-compression via rehydrated handoff - markers never classify as handoff content (classify_summary_content / _strip_context_summary_handoff_message untouched) - SKILLS_GUIDANCE Skill Safety Rule renders with real newlines
This was referenced Jul 24, 2026
randlee
pushed a commit
to randlee/hermes-agent
that referenced
this pull request
Aug 11, 2026
…tected prune, real-compress survival 21 tests pinning the salvaged NousResearch#44166 behavior: - marker emit + extractor round trip (patterns adapted from PR NousResearch#32375 by @LeonSGP43, with credit) - no-duplicate re-injection when the canonical marker survived (the original PR's presence-check defect) - Phase-1 protection for just-loaded / user-referenced skills, and the Pass-4 pressure override that keeps NousResearch#61932 fixed - deterministic marker survival through a REAL compress() with a mocked aux LLM: drop → re-injected, keep → not duplicated, static-fallback path, iterative re-compression via rehydrated handoff - markers never classify as handoff content (classify_summary_content / _strip_context_summary_handoff_message untouched) - SKILLS_GUIDANCE Skill Safety Rule renders with real newlines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill_viewtool results with an explicit[SKILL_PRUNED]reload markerskills_listandskill_managesummaries metadata-onlyskill_viewmarker behaviorTesting
uv run --frozen pytest -q -o addopts= tests/agent/test_context_compressor.py -k 'skill_view_summary_marks_pruned_content or other_skill_tool_summaries_remain_metadata_only'\n-uv run --frozen ruff check agent/context_compressor.py tests/agent/test_context_compressor.py\n-git diff --check