Skip to content

fix(bedrock): register AWS credential env vars in subprocess credential blocklist #32374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HiddenPuppy wants to merge 2 commits into from
Closed

fix(bedrock): register AWS credential env vars in subprocess credential blocklist #32374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e8103
fix(bedrock): register AWS credential env vars in subprocess credenti…
HiddenPuppy May 26, 2026
120565f
fix tests and attribution: update bedrock test + add email to AUTHOR_MAP
HiddenPuppy May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion hermes_cli/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,16 @@ class ProviderConfig:
name="AWS Bedrock",
auth_type="aws_sdk",
inference_base_url="https://bedrock-runtime.us-east-1.amazonaws.com",
api_key_env_vars=(),
api_key_env_vars=(
"AWS_ACCESS_KEY_ID",
"AWS_SECRET_ACCESS_KEY",
"AWS_SESSION_TOKEN",
"AWS_BEARER_TOKEN_BEDROCK",
"AWS_PROFILE",
"AWS_DEFAULT_REGION",
"AWS_ROLE_ARN",
"AWS_WEB_IDENTITY_TOKEN_FILE",
),
base_url_env_var="BEDROCK_BASE_URL",
),
"azure-foundry": ProviderConfig(
Expand Down
1 change: 1 addition & 0 deletions scripts/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@
"xiahu889889@proton.me": "xiahu88988",
"nocoo@users.noreply.github.com": "nocoo",
"30841158+n-WN@users.noreply.github.com": "n-WN",
"hiddenpuppy@users.noreply.github.com": "HiddenPuppy",
"tsuijinglei@gmail.com": "hiddenpuppy",
"buraysandro9@gmail.com": "ygd58",
"jerome@clawwork.ai": "HiddenPuppy",
Expand Down
12 changes: 9 additions & 3 deletions tests/agent/test_bedrock_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,17 @@ def test_bedrock_auth_type_is_aws_sdk(self):
pconfig = PROVIDER_REGISTRY["bedrock"]
assert pconfig.auth_type == "aws_sdk"

def test_bedrock_has_no_api_key_env_vars(self):
"""Bedrock uses the AWS SDK credential chain, not API keys."""
def test_bedrock_has_aws_sdk_env_vars_in_api_key_env_vars(self):
"""Bedrock registers AWS SDK env vars in api_key_env_vars for subprocess blocklisting."""
from hermes_cli.auth import PROVIDER_REGISTRY
pconfig = PROVIDER_REGISTRY["bedrock"]
assert pconfig.api_key_env_vars == ()
aws_vars = pconfig.api_key_env_vars
assert "AWS_ACCESS_KEY_ID" in aws_vars
assert "AWS_SECRET_ACCESS_KEY" in aws_vars
assert "AWS_SESSION_TOKEN" in aws_vars
assert "AWS_BEARER_TOKEN_BEDROCK" in aws_vars
assert "AWS_PROFILE" in aws_vars
assert "AWS_DEFAULT_REGION" in aws_vars

def test_bedrock_base_url_env_var(self):
from hermes_cli.auth import PROVIDER_REGISTRY
Expand Down
Loading