Skip to content

Add iputils-ping (ping) to Docker image - #32015

Merged
benbarclay merged 1 commit into
NousResearch:mainfrom
ninjmnky:add-iputils-ping
May 29, 2026
Merged

Add iputils-ping (ping) to Docker image#32015
benbarclay merged 1 commit into
NousResearch:mainfrom
ninjmnky:add-iputils-ping

Conversation

@ninjmnky

Copy link
Copy Markdown
Contributor

Problem

The official Hermes Agent Docker image does not include ping (from iputils-ping), a fundamental network diagnostic tool that most sysadmins and developers expect to have available out of the box.

Running ping inside the container currently fails with:

ping: command not found

Solution

Add iputils-ping to the apt-get install command in the Dockerfile. This is a one-word, zero-risk change — the package is ~50KB and has no additional dependencies beyond what libc already provides.

Why upstream?

Per the contributing guidelines: "If a tool is likely to be useful to most Hermes Agent users, consider contributing it upstream rather than carrying it in a private derived image."

ping is orders of magnitude more universally useful than most of the utilities already in the image (and far smaller too). Having it missing means every user who needs basic network diagnostics has to fork the image, which is exactly the overhead the guidelines aim to avoid.

Changed

  • Dockerfile: Added iputils-ping to the apt package list.

@ninjmnky
ninjmnky force-pushed the add-iputils-ping branch from 3da8f5f to d0147b8 Compare May 27, 2026 16:05
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have area/docker Docker image, Compose, packaging labels May 27, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.
@ninjmnky
ninjmnky force-pushed the add-iputils-ping branch from d0147b8 to 7be3ce5 Compare May 28, 2026 08:03
@ninjmnky

Copy link
Copy Markdown
Contributor Author

Hey @benbarclay 👋 quick one-line add of iputils-ping to the Dockerfile. Already had to resolve conflicts a couple times as main moved under it — would be great to get this in. Mind taking a look?

@benbarclay
benbarclay merged commit 593e4b4 into NousResearch:main May 29, 2026
@ninjmnky
ninjmnky deleted the add-iputils-ping branch May 29, 2026 04:13
KKT-OPT pushed a commit to KKT-OPT/hermes-agent that referenced this pull request May 31, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
hechuyi pushed a commit to hechuyi/hermes-agent that referenced this pull request Jun 6, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
(cherry picked from commit 593e4b4)
alt-glitch pushed a commit that referenced this pull request Jun 14, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request Jun 18, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
xyshanren pushed a commit to xyshanren/hermes-agent-cn that referenced this pull request Jun 25, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request Jul 13, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
ping is a fundamental network diagnostic tool that most users expect to have available in the container. This adds iputils-ping to the apt install list in the Dockerfile.

Co-authored-by: ninjmnky <ninjmnky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker Docker image, Compose, packaging P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants