Skip to content

fix(ci): add time.sleep(1.0) yield to prevent ASGI TestClient broadcast race #31914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talwayh1 wants to merge 1 commit into from
Closed

fix(ci): add time.sleep(1.0) yield to prevent ASGI TestClient broadcast race #31914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/hermes_cli/test_web_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2341,6 +2341,7 @@ def test_pub_broadcasts_to_events_subscribers(self, monkeypatch):
# receive_text(). Without this, under heavy CI load the
# receive can race the broadcast and hang until
# pytest-timeout kills us.
time.sleep(1.0)
import queue, threading
recv_q: queue.Queue = queue.Queue()

Expand All @@ -2353,10 +2354,10 @@ def _recv():
t = threading.Thread(target=_recv, daemon=True)
t.start()
try:
received = recv_q.get(timeout=10.0)
received = recv_q.get(timeout=30.0)
except queue.Empty:
raise AssertionError(
"broadcast not received within 10s — server likely "
"broadcast not received within 30s — server likely "
"dropped the frame silently (see _broadcast_event "
"except Exception: pass)"
)
Expand Down