fix(discord): decouple free_response_channels from auto_thread suppression - #31852
Closed
Shalmus wants to merge 1 commit into
Closed
fix(discord): decouple free_response_channels from auto_thread suppression#31852Shalmus wants to merge 1 commit into
Shalmus wants to merge 1 commit into
Conversation
…ssion free_response_channels controls whether @mention is required to respond. It was incorrectly OR'd into skip_thread, which disabled auto-threading in any channel that was configured as a free-response channel. DISCORD_NO_THREAD_CHANNELS is the dedicated mechanism for disabling auto-threading in specific channels. This fix removes the conflation so free_response_channels only affects mention-gating as intended.
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
free_response_channelscontrols whether @mention is required for the bot to respond in a channel. It was incorrectly OR'd intoskip_thread, which suppressed auto-threading in any channel configured as a free-response channel.The bug
A channel listed in
free_response_channels(no @mention required) would silently lose auto-threading.DISCORD_NO_THREAD_CHANNELSalready exists as the dedicated mechanism for disabling auto-threading.The fix
Context
I'm a Hermes user, not a developer. Hermes (the agent) helped me diagnose this when I noticed conversations in my free-response channels weren't auto-threading. The root cause was traced to this single line conflating mention-gating with thread creation.
— Submitted by Shalmus with assistance from Hermes Agent