fix(cli): honor skills in oneshot mode - #31656
Closed
Nigelkil01 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Thanks for catching that — I missed the existing PR during triage. Closing this as a duplicate to avoid wasting maintainer time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skillsthrough to oneshot modeTest Plan
pytest tests/hermes_cli/test_tui_resume_flow.py::test_termux_fast_cli_launch_oneshot_uses_light_parser tests/hermes_cli/test_tui_resume_flow.py::test_main_top_level_oneshot_accepts_toolsets tests/hermes_cli/test_tui_resume_flow.py::test_main_top_level_oneshot_accepts_skills tests/hermes_cli/test_tui_resume_flow.py::test_oneshot_preloads_skills_into_ephemeral_system_prompt -o addopts='' -qpytest tests/hermes_cli/test_tui_resume_flow.py -o addopts='' -qpython -m py_compile hermes_cli/oneshot.py hermes_cli/main.py tests/hermes_cli/test_tui_resume_flow.pygit diff --checkFixes #31548