Skip to content

fix(cli): honor skills in oneshot mode - #31656

Closed
Nigelkil01 wants to merge 1 commit into
NousResearch:mainfrom
Nigelkil01:fix/oneshot-skills
Closed

fix(cli): honor skills in oneshot mode#31656
Nigelkil01 wants to merge 1 commit into
NousResearch:mainfrom
Nigelkil01:fix/oneshot-skills

Conversation

@Nigelkil01

Copy link
Copy Markdown

Summary

  • Thread top-level and Termux fast-path --skills through to oneshot mode
  • Preload requested skills with the same skill prompt builder used by chat mode
  • Fail loudly when oneshot receives an unknown skill instead of silently ignoring it

Test Plan

  • pytest tests/hermes_cli/test_tui_resume_flow.py::test_termux_fast_cli_launch_oneshot_uses_light_parser tests/hermes_cli/test_tui_resume_flow.py::test_main_top_level_oneshot_accepts_toolsets tests/hermes_cli/test_tui_resume_flow.py::test_main_top_level_oneshot_accepts_skills tests/hermes_cli/test_tui_resume_flow.py::test_oneshot_preloads_skills_into_ephemeral_system_prompt -o addopts='' -q
  • pytest tests/hermes_cli/test_tui_resume_flow.py -o addopts='' -q
  • python -m py_compile hermes_cli/oneshot.py hermes_cli/main.py tests/hermes_cli/test_tui_resume_flow.py
  • git diff --check

Fixes #31548

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels May 24, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #31591 — both fix #31548 (oneshot mode silently drops --skills flag). Same files changed, same fix approach.

@Nigelkil01

Copy link
Copy Markdown
Author

Thanks for catching that — I missed the existing PR during triage. Closing this as a duplicate to avoid wasting maintainer time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hermes -z (oneshot) discards --skills silently

2 participants