[withdrawn] PR #31533 - #31533
Closed
e-shizz wants to merge 1 commit into
Closed
Conversation
e-shizz
force-pushed
the
fix/matrix-bang-command-prefix
branch
2 times, most recently
from
May 24, 2026 15:04
b0690a2 to
90271fd
Compare
e-shizz
changed the title
alt-glitch
added
type/docs
Collaborator
e-shizz
force-pushed
the
fix/matrix-bang-command-prefix
branch
from
May 24, 2026 15:15
90271fd to
a59b80e
Compare
e-shizz
changed the title
Matrix uses '!' as its bot command prefix convention (e.g. !sethome, !help), but the core command dispatch (MessageEvent.get_command()) only recognises the '/' prefix. This caused all '!' commands to be silently treated as regular user text. Fix: rewrite '!' → '/' in the Matrix adapter's text message handler before creating the MessageEvent. Same pattern as the Slack adapter's existing workaround (slack.py:1804). Also updates the Matrix setup docs to recommend '!' as the primary command prefix, noting that '/' also works.
e-shizz
force-pushed
the
fix/matrix-bang-command-prefix
branch
from
May 24, 2026 15:17
a59b80e to
b88a68d
Compare
13 tasks
Contributor
|
Thanks for the Matrix command-prefix report and documentation update. This automated hermes-sweeper review found the requested behavior is already implemented on current main.
The May 24 discussion’s related bang-prefix work is therefore covered by the current, more complete implementation. |
teknium1
added
the
sweeper:implemented-on-main
e-shizz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn by author. The source fork has been removed.