fix(gateway): stream synthesized recovery finals - #31475
Closed
BROCCOLO1D wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by a replacement PR with the same diff and corrected GitHub noreply author attribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_delta_callbackbefore recovery/guardrail branches close the turn.Why
partial_stream_recoveryandfallback_prior_turn_contentassignfinal_responsefrom local recovery text and then break without another model delta.Changes
agent/conversation_loop.py: adds a small helper for synthesized final deltas and uses it for guardrail halt, partial stream recovery, and prior-turn fallback finals.tests/run_agent/test_run_agent.py: asserts partial-stream recovery and prior-turn fallback text is emitted to stream consumers.Validation
python -m ruff check agent/conversation_loop.py tests/run_agent/test_run_agent.pypython -m pytest tests/run_agent/test_tool_call_guardrail_runtime.py tests/run_agent/test_run_agent.py::TestRunConversation::test_partial_stream_recovery_on_empty_stub tests/run_agent/test_run_agent.py::TestRunConversation::test_prior_turn_fallback_emits_stream_delta -o 'addopts=' -qScope