Skip to content

fix(kanban): migrate additive columns before indexing - #31300

Closed
sunwz1115 wants to merge 1 commit into
NousResearch:mainfrom
sunwz1115:fix/kanban-additive-columns-before-indexes
Closed

fix(kanban): migrate additive columns before indexing#31300
sunwz1115 wants to merge 1 commit into
NousResearch:mainfrom
sunwz1115:fix/kanban-additive-columns-before-indexes

Conversation

@sunwz1115

Copy link
Copy Markdown
Contributor

Summary

  • Ensure legacy Kanban board databases add session_id/run_id before indexes over those additive columns are created.
  • Add regression coverage for the legacy board shape.

Test Plan

  • tests/hermes_cli/test_kanban_db_init.py

Uploaded from LangLang production local patch after rebasing on the latest origin/main.

Move indexes over additive columns out of SCHEMA_SQL so legacy Kanban boards add session_id/run_id before idx_tasks_session_id/idx_events_run are created. Add regression coverage for the legacy board shape.
@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have labels May 24, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #28781 (merged) — comprehensive fix that hoists all 4 additive-column indexes out of SCHEMA_SQL. Also overlaps with #28461, #28602, #28816, #29203.

@teknium1

Copy link
Copy Markdown
Contributor

Closing as already fixed on main.

Triage notes (high confidence):
origin/main hermes_cli/kanban_db.py:1348-1369 already adds session_id/run_id columns before creating idx_tasks_session_id and idx_events_run; PR diff only removes one blank line in production code, the test is the only substantive addition.

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants