Skip to content

fix(setup): install missing Matrix E2EE companion deps - #31232

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:hermes/fix-31116-matrix-e2ee-lazy-deps
Closed

fix(setup): install missing Matrix E2EE companion deps#31232
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:hermes/fix-31116-matrix-e2ee-lazy-deps

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • install the missing platform.matrix package specs during setup wizard E2EE flows instead of only installing mautrix[encryption]
  • keep the non-E2EE path unchanged while improving the manual recovery hint for failed E2EE installs
  • add a setup regression test that proves a missing companion dependency like asyncpg is included in the install command

Testing

  • /Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/.base/.venv/bin/python -m pytest -q -o addopts='' tests/hermes_cli/test_setup_matrix_e2ee.py
  • source /Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/.base/.venv/bin/activate && python -m ruff check hermes_cli/setup.py tests/hermes_cli/test_setup_matrix_e2ee.py
  • git diff --check

Closes #31116.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard platform/matrix Matrix adapter (E2EE) P1 High — major feature broken, no workaround duplicate This issue or pull request already exists labels May 24, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Subset of #31236, which fixes both the Matrix E2EE missing deps and the Discord auto-enable issue from #31116. This PR only addresses the E2EE deps portion.

@teknium1

Copy link
Copy Markdown
Contributor

This looks implemented on current main; closing as superseded by the merged fix. This is an automated hermes-sweeper review.

Evidence:

  • hermes_cli/setup.py:1957 now routes the Matrix E2EE setup path through the central lazy-deps feature group and calls _lazy_ensure("platform.matrix", prompt=False) instead of only installing mautrix[encryption].
  • tools/lazy_deps.py:136 defines platform.matrix with the companion dependencies this PR was adding: mautrix[encryption], aiosqlite, asyncpg, and aiohttp-socks.
  • The implementation is from 54e61f93318d579b145421c447437ec345021eb1 (fix(matrix,gateway): Matrix E2EE installs full dep set; plugins respect is_connected), which is contained in release tag v2026.5.28.
  • The existing maintainer discussion also identifies this PR as the E2EE-deps subset of fix(gateway+setup): repair Matrix E2EE deps and stop Discord auto-enable on fresh installs (#31116) #31236, whose fix landed via that same commit.

@teknium1 teknium1 closed this Jun 21, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard duplicate This issue or pull request already exists P1 High — major feature broken, no workaround platform/matrix Matrix adapter (E2EE) sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Matrix gateway configuration on a fresh install does not install properly

3 participants