fix(qqbot): raise RuntimeError in _read_events when WebSocket is closed - #31151
Closed
ilonagaja509-glitch wants to merge 1 commit into
Closed
ilonagaja509-glitch wants to merge 1 commit into
ilonagaja509-glitch wants to merge 1 commit into
Conversation
When reconnect fails (e.g., _get_gateway_url() times out), the old closed WebSocket object was not None but had closed=True. The guard passed, but the while loop never executed, causing _read_events to return silently. This led to an infinite silent loop with no retry attempts. Fix by checking both and in the guard. Fixes NousResearch#31101
alt-glitch
added
type/bug
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reconnect fails (e.g., _get_gateway_url() times out), the old closed WebSocket object was not None but had closed=True. The guard
if not self._wspassed, but the while loopwhile self._ws and not self._ws.closednever executed, causing _read_events to return silently. This led to an infinite silent loop with no retry attempts.Fix by checking both
not self._wsandself._ws.closedin the guard.Fixes #31101
Checklist