test: keep tirith checks hermetic - #30844
Merged
Merged
Conversation
Contributor
🔎 Lint report:
|
19 tasks
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvages the hermeticity-only half of #30643 — five tests no longer depend on host state (cosign installed, PID 42 alive, host WSL kernel, host auxiliary credentials, Tirith auto-install). Drops the
min(4, cpu_count)worker cap from that PR; we want more parallelism, not less.Changes
tests/conftest.py: setTIRITH_ENABLED=falsein the hermetic fixture so unit tests never trigger Tirith's GitHub auto-installtests/tools/test_tirith_security.py: patchshutil.whichfor the cosign-missing branch so the assertion holds regardless of whether the host has cosigntests/gateway/test_runner_startup_failures.py: stub_pid_existsso the replace/force startup test doesn't depend on PID 42 being alive on the hosttests/agent/test_context_compressor.py: explicitly simulate no-summarizer viacall_llmside_effect (was discovering real auxiliary credentials from auth state)tests/tools/test_voice_mode.py: shim/proc/versionfor the non-WSL paths so the tests work on WSL hosts tooValidation
scripts/run_tests.sh tests/agent/test_context_compressor.py tests/gateway/test_runner_startup_failures.py tests/tools/test_voice_mode.py tests/tools/test_tirith_security.py→ 244/244 passed.Credit: @helix4u (original PR #30643).
Infographic