Propagate chat completion model to Codex provider - #30767
Closed
Backlisted wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Many thanks — understood. This PR came from a SafeHouse integration proof where `/v1/chat/completions` received a non-empty request model but the Codex provider path fell back to an empty/default model before agent creation. I’ll compare against #10773 and close this as duplicate if that PR fully covers the same routing path.
If there is a preferred branch/commit to pin against for downstream integration testing, please point me to it.
…________________________________
From: Siddharth Balyan ***@***.***>
Sent: Saturday, 23 May 2026 3:43 PM
To: NousResearch/hermes-agent ***@***.***>
Cc: Justin Cussel ***@***.***>; Author ***@***.***>
Subject: Re: [NousResearch/hermes-agent] Propagate chat completion model to Codex provider (PR #30767)
[https://avatars.githubusercontent.com/u/52913345?s=20&v=4]alt-glitch left a comment (NousResearch/hermes-agent#30767)<#30767 (comment)>
Duplicate of #10773<#10773> — same per-request model routing fix for /v1/chat/completions. See also #25552<#25552> (already flagged as dup of #10773<#10773>), #24008<#24008>, #16403<#16403>, #18549<#18549>, #5862<#5862>.
—
Reply to this email directly, view it on GitHub<#30767 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHA7L4NGBZ4GACMVFXBQ5YL44E3BRAVCNFSM6AAAAACZKC22CKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKMRUGMYTAMZYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes /v1/chat/completions dropping request.model before Codex agent creation. Required for SafeHouse real-provider strict JSON proof.